Skip to content

Fix the SMS text message for phone verification #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

Fix the SMS text message for phone verification #527

merged 1 commit into from
Apr 23, 2025

Conversation

alexeykazakov
Copy link
Contributor

No description provided.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
50.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kyetter
Copy link

kyetter commented Apr 22, 2025

https://redhat-internal.slack.com/archives/C085PFGDLGY/p1745342399143459 for context :)

@codecov Codecov
Copy link

codecov bot commented Apr 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.09%. Comparing base (b52c1dc) to head (efde923).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #527   +/-   ##
=======================================
  Coverage   81.09%   81.09%           
=======================================
  Files          43       43           
  Lines        3518     3518           
=======================================
  Hits         2853     2853           
  Misses        578      578           
  Partials       87       87
Flag Coverage Δ
unittests 81.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MatousJobanek MatousJobanek merged commit 291379f into codeready-toolchain:master Apr 23, 2025
11 of 13 checks passed
@alexeykazakov alexeykazakov deleted the text branch April 23, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatousJobanek MatousJobanek MatousJobanek approved these changes

@xcoulon xcoulon Awaiting requested review from xcoulon

@rajivnathan rajivnathan Awaiting requested review from rajivnathan

@mfrancisc mfrancisc Awaiting requested review from mfrancisc

@rsoaresd rsoaresd Awaiting requested review from rsoaresd

@fbm3307 fbm3307 Awaiting requested review from fbm3307

@metlos metlos Awaiting requested review from metlos

@jrosental jrosental Awaiting requested review from jrosental

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexeykazakov @kyetter @MatousJobanek